Factor out udp_tx stats update

quinn-rs · Jan 23, 2024 · 86bac4b · 86bac4b
1 parent 7a38428
commit 86bac4b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/quinn-proto/src/connection/mod.rs b/quinn-proto/src/connection/mod.rs
@@ -508,9 +508,7 @@ impl Connection {
                 builder.pad_to(MIN_INITIAL_SIZE);
 
                 builder.finish(self, buf);
-                self.stats.udp_tx.datagrams += 1;
-                self.stats.udp_tx.ios += 1;
-                self.stats.udp_tx.bytes += buf.len() as u64;
+                self.stats.udp_tx.on_sent(1, buf.len());
                 return Some(Transmit {
                     destination,
                     size: buf.len(),
@@ -900,9 +898,7 @@ impl Connection {
         trace!("sending {} bytes in {} datagrams", buf.len(), num_datagrams);
         self.path.total_sent = self.path.total_sent.saturating_add(buf.len() as u64);
 
-        self.stats.udp_tx.datagrams += num_datagrams as u64;
-        self.stats.udp_tx.bytes += buf.len() as u64;
-        self.stats.udp_tx.ios += 1;
+        self.stats.udp_tx.on_sent(num_datagrams as u64, buf.len());
 
         Some(Transmit {
             destination: self.path.remote,

diff --git a/quinn-proto/src/connection/stats.rs b/quinn-proto/src/connection/stats.rs
@@ -17,6 +17,14 @@ pub struct UdpStats {
     pub ios: u64,
 }
 
+impl UdpStats {
+    pub(crate) fn on_sent(&mut self, datagrams: u64, bytes: usize) {
+        self.datagrams += datagrams;
+        self.bytes += bytes as u64;
+        self.ios += 1;
+    }
+}
+
 /// Number of frames transmitted of each frame type
 #[derive(Default, Copy, Clone)]
 #[non_exhaustive]