Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XFIXES extension to receive selection notifications. #12

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Use XFIXES extension to receive selection notifications. #12

merged 1 commit into from
Feb 1, 2019

Conversation

slp
Copy link
Contributor

@slp slp commented Jan 17, 2019

I happily and carelessly broke the API while implementing this. If you'd prefer to provide backward compatibility, please let me know and I'll implement it too.

Fixes #3

@quininer
Copy link
Owner

Very happy to see this PR, I always wanted this!

I also want backward compatibility.

@eatradish eatradish mentioned this pull request Jan 17, 2019
This change implements load_wait, a new method that waits for a change
in the clipboard using XFIXES and returns the new value of the selected
property.
@slp
Copy link
Contributor Author

slp commented Feb 1, 2019

@quininer I came up with a different implementation that maintains API compat with previous releases, while added the new method "load_wait". Please take a look at it and let me know your opinion.

@quininer
Copy link
Owner

quininer commented Feb 1, 2019

Great work! I realized this has some overhead compared to previous API, but I am already satisfied.

@quininer quininer merged commit cf44aa8 into quininer:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants