Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2962 Setting run type aliases when uploading files isn't working #2963

Conversation

squaregoldfish
Copy link
Collaborator

Fix #2962

When an instrument has multiple file definitions, and at least one has no run type column, uploading new files with missing run types would fail.
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.20%. Comparing base (b6bae08) to head (c06f1c5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../exeter/QuinCe/data/Instrument/FileDefinition.java 0.00% 2 Missing ⚠️
.../uk/ac/exeter/QuinCe/web/files/MissingRunType.java 0.00% 1 Missing ⚠️
...xeter/QuinCe/web/files/MultipleFileUploadBean.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2963      +/-   ##
============================================
- Coverage     29.20%   29.20%   -0.01%     
  Complexity     1972     1972              
============================================
  Files           386      386              
  Lines         19854    19855       +1     
  Branches       2660     2659       -1     
============================================
  Hits           5798     5798              
- Misses        13645    13646       +1     
  Partials        411      411              
Flag Coverage Δ
unittests 29.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squaregoldfish squaregoldfish merged commit 9343854 into quince-science:master Sep 11, 2024
3 of 4 checks passed
@squaregoldfish squaregoldfish deleted the 2962-setting-run-type-aliases-when-uploading-files-isnt-working branch September 11, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting run type aliases when uploading files isn't working
1 participant