Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4215: More informative error messages when package construction fails #4216

Merged
merged 27 commits into from
Nov 21, 2024

Conversation

drernie
Copy link
Member

@drernie drernie commented Nov 14, 2024

Description

Ensure we return sufficient information on errors to enable efficient debugging.

TODO

  • Unit tests
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@drernie drernie linked an issue Nov 14, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.27%. Comparing base (ccdcab9) to head (c80414d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
api/python/quilt3/packages.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4216      +/-   ##
==========================================
+ Coverage   39.16%   39.27%   +0.10%     
==========================================
  Files         775      775              
  Lines       35086    35132      +46     
  Branches     5294     5294              
==========================================
+ Hits        13743    13798      +55     
+ Misses      20146    20137       -9     
  Partials     1197     1197              
Flag Coverage Δ
api-python 91.29% <96.55%> (+0.18%) ⬆️
catalog 14.57% <ø> (ø)
lambda 92.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@drernie drernie marked this pull request as ready for review November 15, 2024 03:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

@drernie drernie requested a review from nl0 November 19, 2024 16:11
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some nitpicks

api/python/quilt3/packages.py Outdated Show resolved Hide resolved
api/python/quilt3/packages.py Outdated Show resolved Hide resolved
@nl0 nl0 changed the title 4215 more informative error for already a packageentry More informative error for already a packageentry Nov 20, 2024
@nl0 nl0 changed the title More informative error for already a packageentry More informative error messages when package construction fails Nov 20, 2024
Copy link
Member

@sir-sigurd sir-sigurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please start use common convention of referencing GH issues in PR titles/commit messages?

e.g. fix #NNN: some message

api/python/quilt3/packages.py Outdated Show resolved Hide resolved
api/python/quilt3/packages.py Outdated Show resolved Hide resolved
api/python/quilt3/packages.py Outdated Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
@drernie drernie changed the title More informative error messages when package construction fails fix #4215: More informative error messages when package construction fails Nov 21, 2024
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @sir-sigurd pls approve if looks good to you too

@drernie drernie added this pull request to the merge queue Nov 21, 2024
Merged via the queue into master with commit f6182d0 Nov 21, 2024
38 checks passed
@drernie drernie deleted the 4215-more-informative-error-for-already-a-packageentry branch November 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More informative error for "Already a PackageEntry"
3 participants