-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #4215: More informative error messages when package construction fails #4216
fix #4215: More informative error messages when package construction fails #4216
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4216 +/- ##
==========================================
+ Coverage 39.16% 39.27% +0.10%
==========================================
Files 775 775
Lines 35086 35132 +46
Branches 5294 5294
==========================================
+ Hits 13743 13798 +55
+ Misses 20146 20137 -9
Partials 1197 1197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, some nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please start use common convention of referencing GH issues in PR titles/commit messages?
e.g. fix #NNN: some message
Co-authored-by: Sergey Fedoseev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @sir-sigurd pls approve if looks good to you too
Description
Ensure we return sufficient information on errors to enable efficient debugging.
TODO