-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quilt3.get_boto3_session() function #4169
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4169 +/- ##
==========================================
+ Coverage 37.73% 37.80% +0.07%
==========================================
Files 766 766
Lines 35152 35195 +43
Branches 5190 5190
==========================================
+ Hits 13264 13307 +43
Misses 20656 20656
Partials 1232 1232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
75cfd57
to
c55e7a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This provides public API for creation of boto3 session with stack credentials/region.
This also should reduce number of S3 requests (1 per non us-east-1 bucket (assuming buckets are in the stack region)) 🚀.
TODO
build.py
for new docstrings