Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quilt3.get_boto3_session() function #4169

Merged
merged 8 commits into from
Oct 14, 2024
Merged

add quilt3.get_boto3_session() function #4169

merged 8 commits into from
Oct 14, 2024

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Oct 10, 2024

Description

This provides public API for creation of boto3 session with stack credentials/region.
This also should reduce number of S3 requests (1 per non us-east-1 bucket (assuming buckets are in the stack region)) 🚀.

TODO

  • Unit tests
  • Documentation
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.80%. Comparing base (229e313) to head (c5c6932).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4169      +/-   ##
==========================================
+ Coverage   37.73%   37.80%   +0.07%     
==========================================
  Files         766      766              
  Lines       35152    35195      +43     
  Branches     5190     5190              
==========================================
+ Hits        13264    13307      +43     
  Misses      20656    20656              
  Partials     1232     1232              
Flag Coverage Δ
api-python 91.09% <100.00%> (+0.05%) ⬆️
catalog 12.12% <ø> (ø)
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sir-sigurd sir-sigurd requested a review from nl0 October 11, 2024 12:24
nl0
nl0 previously approved these changes Oct 11, 2024
@sir-sigurd sir-sigurd marked this pull request as ready for review October 14, 2024 13:53
@sir-sigurd sir-sigurd requested a review from nl0 October 14, 2024 13:54
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sir-sigurd sir-sigurd added this pull request to the merge queue Oct 14, 2024
Merged via the queue into master with commit c7eb9a7 Oct 14, 2024
38 checks passed
@sir-sigurd sir-sigurd deleted the boto3-session branch October 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants