Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Google Tag Manager #4039

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Remove Google Tag Manager #4039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f57c13d
Remove Google Tag Manager
fiskus Jul 1, 2024
e2377ab
add changelog entry
fiskus Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions catalog/app/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import 'sanitize.css'
import * as Intercom from 'components/Intercom'
import Placeholder from 'components/Placeholder'
import App from 'containers/App'
import GTMLoader from 'utils/gtm'
import * as Auth from 'containers/Auth'
import * as Errors from 'containers/Errors'
import * as Notifications from 'containers/Notifications'
Expand Down Expand Up @@ -105,7 +104,6 @@ const render = () => {
Notifications.Provider,
[APIConnector.Provider, { fetch, middleware: [Auth.apiMiddleware] }],
[Auth.Provider, { storage }],
[GTMLoader, { gtmId: cfg.gtmId }],
[
Intercom.Provider,
{
Expand Down
1 change: 0 additions & 1 deletion catalog/app/utils/Config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export interface ConfigJson {
registryUrl: string
s3Proxy: string

gtmId?: string
intercomAppId?: string
mixpanelToken: string
sentryDSN?: string
Expand Down
68 changes: 0 additions & 68 deletions catalog/app/utils/gtm.tsx
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions catalog/config-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@
"type": "string",
"description": "Optional"
},
"gtmId": {
"type": "string",
"description": "ID for Google TagManager/Analytics service"
},
"qurator": {
"type": "boolean",
"description": "Enable Qurator AI Assistant (powered by AWS Bedrock)"
Expand Down
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Entries inside each section should be ordered by type:

## Catalog, Lambdas
* [Removed] Drop MARKETING mode support, delete associated dead code ([#4009](https://github.com/quiltdata/quilt/pull/4009))
* [Removed] Delete Google Tag Manager script integration ([#4039](https://github.com/quiltdata/quilt/pull/4039))
* [Added] Support multiple roles per user ([#3982](https://github.com/quiltdata/quilt/pull/3982))
* [Added] Add `ui.actions = False` and `ui.actions.writeFile` for configuring visibility of buttons ([#4001](https://github.com/quiltdata/quilt/pull/4001))
* [Added] Support creating folders and rearranging entries with drag and drop in package creation dialog ([#3999](https://github.com/quiltdata/quilt/pull/3999))
Expand Down