Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all actions by actions = false #4001

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Disable all actions by actions = false #4001

merged 3 commits into from
Jun 19, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jun 14, 2024

  • Added ui.actions.writeFile for hiding "Create file" and "Edit file" buttons
  • Added ui.actions = False to hide all buttons, making catalog "Read-only"
  • Strengthen existing tests using toEqual instead toMatchObject and add new
  • Unit tests
  • Documentation
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 37.19%. Comparing base (92cf38f) to head (63a5cd2).

Files Patch % Lines
catalog/app/containers/Bucket/Dir.tsx 0.00% 10 Missing ⚠️
catalog/app/containers/Bucket/File.js 0.00% 7 Missing and 2 partials ⚠️
...app/containers/Bucket/PackageTree/RevisionMenu.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4001      +/-   ##
==========================================
- Coverage   37.19%   37.19%   -0.01%     
==========================================
  Files         757      757              
  Lines       33114    33135      +21     
  Branches     4676     4683       +7     
==========================================
+ Hits        12318    12323       +5     
- Misses      20154    20168      +14     
- Partials      642      644       +2     
Flag Coverage Δ
api-python 90.75% <ø> (ø)
catalog 10.56% <20.00%> (+0.01%) ⬆️
lambda 88.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus marked this pull request as ready for review June 17, 2024 12:26
@fiskus fiskus requested a review from nl0 June 17, 2024 12:26
nl0
nl0 previously approved these changes Jun 18, 2024
docs/Catalog/Preferences.md Outdated Show resolved Hide resolved
@fiskus
Copy link
Member Author

fiskus commented Jun 18, 2024

Squashed commits

nl0
nl0 previously approved these changes Jun 19, 2024
@fiskus fiskus added this pull request to the merge queue Jun 19, 2024
@nl0 nl0 removed this pull request from the merge queue due to a manual request Jun 19, 2024
@nl0 nl0 added this pull request to the merge queue Jun 19, 2024
Merged via the queue into master with commit 3e55c58 Jun 19, 2024
36 of 38 checks passed
@nl0 nl0 deleted the disable-all-actions branch June 19, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants