Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 support #3993

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Drop Python 3.8 support #3993

merged 2 commits into from
Jun 5, 2024

Conversation

sir-sigurd
Copy link
Member

Description

TODO

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@sir-sigurd sir-sigurd requested a review from nl0 June 5, 2024 06:09
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.68%. Comparing base (cdb6fe4) to head (8a8fd27).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3993   +/-   ##
=======================================
  Coverage   36.68%   36.68%           
=======================================
  Files         724      724           
  Lines       32254    32254           
  Branches     4773     4773           
=======================================
  Hits        11833    11833           
  Misses      19758    19758           
  Partials      663      663           
Flag Coverage Δ
api-python 90.95% <ø> (ø)
catalog 10.70% <ø> (ø)
lambda 87.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sir-sigurd sir-sigurd enabled auto-merge June 5, 2024 06:22
@sir-sigurd sir-sigurd added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit e89c02f Jun 5, 2024
38 checks passed
@sir-sigurd sir-sigurd deleted the drop-3.8 branch June 5, 2024 07:24
nl0 added a commit that referenced this pull request Jun 11, 2024
* master:
  Always use stdlib importlib.metadata (#3997)
  Better class signatures in docs (#3996)
  Bump tornado from 6.3.3 to 6.4.1 in /lambdas/preview (#3995)
  Bump amazonlinux from 2023.4.20240416.0 to 2023.4.20240528.0 in /catalog (#3991)
  Bump amazonlinux from 2023.4.20240416.0 to 2023.4.20240528.0 in /s3-proxy (#3992)
  Drop Python 3.8 support (#3993)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants