Use promises for URLs in IGV to have fresh signing each time they used

[fiskus]

• Changelog entry (skip if change is not significant to end users, e.g. docs only)

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 36.68%. Comparing base (9ea699f) to head (4d22715).

Files	Patch %	Lines
catalog/app/components/Preview/loaders/Igv.ts	0.00%	3 Missing ⚠️
...pp/components/Preview/loaders/useSignObjectUrls.ts	66.66%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
+ Coverage   36.56%   36.68%   +0.11%     
==========================================
  Files         724      724              
  Lines       32248    32254       +6     
  Branches     4605     4773     +168     
==========================================
+ Hits        11793    11833      +40     
+ Misses      19792    19259     -533     
- Partials      663     1162     +499     

Flag	Coverage Δ
api-python	90.95% <ø> (ø)
catalog	10.70% <50.00%> (+0.18%)	⬆️
lambda	87.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nl0]

i don't quite get it -- is IGV able to accept async thunks instead of strings as URLs?

[fiskus]

is IGV able to accept async thunks instead of strings as URLs?

Yes, it is. Sorry, I didn't add this to the PR description.
They use their own helper module for every URL (though in documentation they said only about tracks URLs), and it nailed down to that function where it is a check if URL is a string or a function, and those functions or strings could be async:
https://github.com/igvteam/igv-utils/blob/master/src/igvxhr.js#L91

[fiskus]

I can pass thunks but if indexURL or indexFile is omitted, they try to guess it, and it produces invalid URL like function(){}.fai. I filed a bug and fix igvteam/igv.js#1821
Hope they accept it, so I can remove our hacky fix: https://github.com/quiltdata/quilt/pull/3979/files#diff-6add50e55b85715ee3b4fb41a53452478a83ba438d1f94230d83bb7e6ba6d0acR81

[nl0]

Hope they accept it

looks like they did. not sure when they're going to cut their next release tho