Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate checksum from local file if upload optimization succeeds #3968

Merged
merged 10 commits into from
Jun 18, 2024
Merged

Calculate checksum from local file if upload optimization succeeds #3968

merged 10 commits into from
Jun 18, 2024

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Apr 30, 2024 •
edited
Loading

Description

TODO

  • Unit tests
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)
  • test with selector_fn

@codecov Codecov
Copy link

codecov bot commented May 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.16981% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.81%. Comparing base (b58a355) to head (b40d45d).
Report is 2 commits behind head on master.

Files Patch % Lines
api/python/quilt3/data_transfer.py 95.52% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3968      +/-   ##
==========================================
+ Coverage   36.68%   36.81%   +0.13%     
==========================================
  Files         724      724              
  Lines       32254    32305      +51     
  Branches     4608     4604       -4     
==========================================
+ Hits        11833    11894      +61     
+ Misses      19758    19748      -10     
  Partials      663      663
Flag Coverage Δ
api-python 91.08% <97.16%> (+0.13%) ⬆️
catalog 10.71% <ø> (+<0.01%) ⬆️
lambda 87.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sir-sigurd sir-sigurd marked this pull request as ready for review May 2, 2024 08:16
@sir-sigurd sir-sigurd requested a review from nl0 May 13, 2024 10:33
nl0
nl0 reviewed May 14, 2024
View reviewed changes
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane, tho i'd make the checksum matching logic stricter

api/python/quilt3/data_transfer.py Outdated Show resolved Hide resolved
api/python/quilt3/data_transfer.py Outdated Show resolved Hide resolved
api/python/quilt3/data_transfer.py Outdated Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
@sir-sigurd sir-sigurd requested a review from nl0 June 13, 2024 12:58
nl0
nl0 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sir-sigurd sir-sigurd added this pull request to the merge queue Jun 18, 2024
Merged via the queue into master with commit 358feaf Jun 18, 2024
38 checks passed
@sir-sigurd sir-sigurd deleted the fix-upload-optimization branch June 18, 2024 05:12
nl0 added a commit that referenced this pull request Jun 18, 2024
@nl0
Merge branch 'master' into users-gql
70a7a24 
* master:
  Quilt3 v6.0.0a4 (#4007)
  GraphQL-based quilt3.admin API (#3990)
  Bump urllib3 from 1.26.18 to 1.26.19 in /lambdas/pkgevents (#4006)
  Bump urllib3 from 1.26.18 to 1.26.19 in /lambdas/status_reports (#4005)
  Calculate checksum from local file if upload optimization succeeds (#3968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nl0 nl0 nl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sir-sigurd @nl0