Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Listing's pagination to the bottom #3950

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Move Listing's pagination to the bottom #3950

merged 6 commits into from
Apr 19, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Apr 17, 2024 •
edited
Loading

  • Moved pagination to the bottom
  • Added message how many rows are rendered
  • Slightly increased pagination controls size
  • Added rows fillers on the last page, so layout doesn't jump
simplescreenrecorder-2024-04-17_18.18.01.webm
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@fiskus fiskus changed the title Move Listing pagination to the bottom Move Listing's pagination to the bottom Apr 17, 2024
@fiskus fiskus requested a review from nl0 April 17, 2024 16:19
nl0
nl0 previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not quite sure about this ux tbh, but whatever

catalog/app/containers/Bucket/Listing.tsx Outdated Show resolved Hide resolved
@fiskus
Copy link
Member Author

fiskus commented Apr 18, 2024

Workaround for layout jump doesn't always work, so I removed it

@fiskus fiskus added this pull request to the merge queue Apr 19, 2024
Merged via the queue into master with commit 7701400 Apr 19, 2024
32 checks passed
@fiskus fiskus deleted the listing-bottom-pagination branch April 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nl0 nl0 nl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiskus @nl0