Add "text" type for quilt_summarize.json
#3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fiskus
commented
Apr 16, 2024
fiskus
commented
- Documentation
- Changelog entry (skip if change is not significant to end users, e.g. docs only)
fiskus
force-pushed
the
quilt-summarize-txt
branch
from
d4b23f4 to
8431b76
Compare
nl0
previously approved these changes
Apr 17, 2024
fiskus
commented
Apr 17, 2024
fiskus
force-pushed
the
quilt-summarize-txt
branch
from
f88e608 to
ecc736b
Compare
|
Merged and rebased |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3946 +/- ##
==========================================
- Coverage 87.80% 84.51% -3.30%
==========================================
Files 71 37 -34
Lines 9639 3235 -6404
==========================================
- Hits 8464 2734 -5730
+ Misses 1175 501 -674
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nl0
previously approved these changes
Apr 17, 2024
fiskus
changed the title
"text" type for quilt_summarize.json
fiskus
force-pushed
the
quilt-summarize-txt
branch
from
6e3fdf8 to
2c9746e
Compare
fiskus
force-pushed
the
quilt-summarize-txt
branch
from
2c9746e to
c8fbe43
Compare
|
Changed "txt" to "text", because it makes more sense in the context of other file types which written using full words ("jupyter", "echarts") |
nl0
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.