Faceted Search #3712

nl0 · 2023-09-07T15:16:23Z

TODO

Changelog entry (skip if change is not significant to end users, e.g. docs only)

codecov · 2023-09-07T15:18:53Z

Codecov Report

Merging #3712 (995b8ff) into master (bf660b0) will decrease coverage by 1.68%.
The diff coverage is 0.57%.

@@            Coverage Diff             @@
##           master    #3712      +/-   ##
==========================================
- Coverage   36.20%   34.52%   -1.68%     
==========================================
  Files         682      707      +25     
  Lines       29907    30944    +1037     
  Branches     4379     4637     +258     
==========================================
- Hits        10827    10684     -143     
- Misses      17957    19111    +1154     
- Partials     1123     1149      +26

Flag	Coverage Δ
api-python	`91.35% <ø> (ø)`
catalog	`9.25% <0.57%> (-0.54%)`	⬇️
lambda	`86.04% <ø> (-0.23%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
catalog/app/components/SearchResults/index.ts	`0.00% <ø> (ø)`
catalog/app/containers/Search/index.ts	`0.00% <ø> (ø)`
catalog/app/model/graphql/schema.generated.ts	`0.00% <ø> (ø)`
catalog/app/utils/JSONPointer.ts	`100.00% <100.00%> (ø)`
catalog/app/utils/search.js	`0.00% <ø> (ø)`
catalog/app/containers/NavBar/Suggestions/index.ts	`0.00% <0.00%> (ø)`
catalog/app/containers/NavBar/index.ts	`0.00% <0.00%> (ø)`
...talog/app/website/pages/OpenLanding/OpenLanding.js	`0.00% <0.00%> (ø)`
.../app/containers/Search/gql/BaseSearch.generated.ts	`0.00% <0.00%> (ø)`
...ontainers/Search/gql/FirstPageObjects.generated.ts	`0.00% <0.00%> (ø)`
... and 35 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

fiskus

I'd like to add global (initial) extents to each filters to highlight what values are not available. I think it could help the user to not get lost

catalog/app/containers/Search/model.tsx

nl0 · 2023-09-20T13:42:37Z

@fiskus pls do a git pull --rebase if conflicts while pushing to avoid introducing unnecessary merge commits

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.15 to 1.26.17. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.15...1.26.17) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.12 to 1.26.17. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.12...1.26.17) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.9 to 1.26.17. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.9...1.26.17) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.4.0 to 10.0.1. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.4.0...10.0.1) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.11 to 1.26.17. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.11...1.26.17) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps debian from bullseye-20230919-slim to bullseye-20231009-slim. --- updated-dependencies: - dependency-name: debian dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…log (#3763) Bumps amazonlinux from 2023.2.20230920.1 to 2023.2.20231011.0. --- updated-dependencies: - dependency-name: amazonlinux dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps amazonlinux from 2023.2.20230920.1 to 2023.2.20231011.0. --- updated-dependencies: - dependency-name: amazonlinux dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Index metadata fields * Index package workflow in ES (#3706) * fix test * use json pointer instead of dot path * index config version id * index text arrays, always put "text" value * fix test * use global logger instead of print * remove a comment * tests * moar tests * lint

nl0 · 2023-10-13T18:05:33Z

@fiskus ima merge this

fiskus reviewed Sep 7, 2023

View reviewed changes

catalog/app/containers/Search/model.tsx Outdated Show resolved Hide resolved

fiskus reviewed Sep 12, 2023

View reviewed changes

catalog/app/containers/Search/model.tsx Outdated Show resolved Hide resolved

fiskus reviewed Sep 12, 2023

View reviewed changes

catalog/app/containers/Search/model.tsx Outdated Show resolved Hide resolved

fiskus reviewed Sep 12, 2023

View reviewed changes

catalog/app/containers/Search/model.tsx Outdated Show resolved Hide resolved

nl0 and others added 16 commits September 20, 2023 13:26

FS WIP

6462213

gql api and ui model WIP

7c13824

more plumbing. now it loads somehow

5043213

update gql schema

0d61211

regen types, update queries

1457238

more plumbing

f5dc586

more plumbing

8d55302

compute filter expression

c3a085a

handle numeric facets

a72df13

adjust schema WIP

79c1519

simplify the model somewhat

dee38d6

further work

cbf2aec

further work

c2e8fb9

further work, working filters

d53cba5

facet query, keyword widget

73e86fe

Max's UI stuff (#3719)

f41838e

nl0 force-pushed the faceted-search branch from fe8dd1b to f41838e Compare September 20, 2023 11:26

nl0 and others added 6 commits September 20, 2023 13:59

utils/JSONPointer: mark path as readonly to fix type errors

3c44674

remove unnecessary types

b3bf0b3

fix date range predicate serialization

98524da

remove unused components, use {min,max} instead of [min, max]

ecd5eb2

merge with remote

d421745

reuse container for both cases

5a511b0

adjusted DatesRange format: [from, to] -> {min, max}

c31e58f

dependabot bot and others added 13 commits October 13, 2023 17:30

rm some unused code

a1a2728

more cleanup

a853a01

Merge branch 'master' into faceted-search

a437f33

nl0 marked this pull request as ready for review October 13, 2023 15:32

nl0 and others added 8 commits October 13, 2023 17:56

remove unused file

05caede

adjust some copy

46a374e

changelog

c2b4dd0

add result type icons

eff4df7

adjust casing

65b6ec1

adjust suggestions copy

91cbe40

adjust suggestions

5214f74

adjust copy

995b8ff

nl0 requested a review from fiskus October 13, 2023 18:05

nl0 enabled auto-merge October 13, 2023 18:16

fiskus approved these changes Oct 13, 2023

View reviewed changes

nl0 added this pull request to the merge queue Oct 13, 2023

Merged via the queue into master with commit 6ba9401 Oct 13, 2023

nl0 deleted the faceted-search branch October 13, 2023 18:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Faceted Search #3712

Faceted Search #3712

nl0 commented Sep 7, 2023 •

edited

Loading

codecov bot commented Sep 7, 2023 •

edited

Loading

fiskus left a comment

nl0 commented Sep 20, 2023

nl0 commented Oct 13, 2023

Faceted Search #3712

Faceted Search #3712

Conversation

nl0 commented Sep 7, 2023 • edited Loading

TODO

codecov bot commented Sep 7, 2023 • edited Loading

Codecov Report

fiskus left a comment

Choose a reason for hiding this comment

nl0 commented Sep 20, 2023

nl0 commented Oct 13, 2023

nl0 commented Sep 7, 2023 •

edited

Loading

codecov bot commented Sep 7, 2023 •

edited

Loading