Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata dropzone: disable click, fix JSON drop #3707

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 31, 2023

Click bug introduced in #3647
And JSON drop bug introduced in #2510

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #3707 (878896b) into master (56425e7) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #3707   +/-   ##
=======================================
  Coverage   36.05%   36.05%           
=======================================
  Files         681      681           
  Lines       29862    29862           
  Branches     4379     4379           
=======================================
  Hits        10768    10768           
  Misses      17971    17971           
  Partials     1123     1123           
Flag Coverage Δ
api-python 91.35% <ø> (ø)
catalog 9.78% <0.00%> (ø)
lambda 86.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../app/containers/Bucket/PackageDialog/MetaInput.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus changed the title Disable click for metadata dropzone Metadata dropzone: disable click, fix JSON drop Aug 31, 2023
@fiskus fiskus requested a review from nl0 August 31, 2023 14:32
@fiskus fiskus requested a review from QuiltSimon August 31, 2023 14:33
@fiskus fiskus enabled auto-merge August 31, 2023 20:02
@fiskus fiskus added this pull request to the merge queue Aug 31, 2023
Merged via the queue into master with commit 9dc817a Aug 31, 2023
38 of 40 checks passed
@fiskus fiskus deleted the fix-metadata-dropzone branch August 31, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants