-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index S3 tags #3691
Index S3 tags #3691
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3691 +/- ##
==========================================
- Coverage 36.12% 28.26% -7.87%
==========================================
Files 677 632 -45
Lines 29677 25643 -4034
Branches 4327 4327
==========================================
- Hits 10720 7247 -3473
+ Misses 17825 17264 -561
Partials 1132 1132
Flags with carried forward coverage won't be shown. Click here to find out more. see 47 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please add a comment and TODO (maybe in the doc string for the function) that we currently do not handle object tagging events therefore, contrary to design (but as agreed per my suggestion) S3 can drift from ES since tag changes do not incur object events that we rely on today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tho indexing tags as key1 value1 key2 value2 ...
feels like a questionable decision tbh
yes, though it was promoted by @akarve |
i don't urge anyone to re-evaluate the solution atm, but we may consider revisiting that some time in the future |
Description
This indexes S3 object tags as text i.e. like this
"key1 value1 key2 value2 ..."
intos3_tags
field.TODO