-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter to Policies and Roles tables, refactor filter #3690
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3690 +/- ##
==========================================
- Coverage 36.14% 36.14% -0.01%
==========================================
Files 678 680 +2
Lines 29792 29778 -14
Branches 4348 4343 -5
==========================================
- Hits 10769 10763 -6
- Misses 17890 17895 +5
+ Partials 1133 1120 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 40 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see a fundamental design issue here -- filtering should not be an "extension" for ordering. instead, it should be a standalone composable unit (a hook in this case), which gets applied before ordering and its application result is be passed down to ordering as an input
i'd suggest to rename |
7515d59
to
aa875ae
Compare
I rewrote the code, moving filter outside |
catalog/app/containers/Admin/RolesAndPolicies/AttachedPolicies.tsx
Outdated
Show resolved
Hide resolved
catalog/app/containers/Admin/RolesAndPolicies/BucketsPermissions.tsx
Outdated
Show resolved
Hide resolved
Resolved CHANGELOG conflict, added types, and squashed commits. I described new commits in comments |
Moved repeatable filter code toCreatedTable.useOrdering
Table.useFiltering
Table
to Typescript (splitted code to typed.tsx and untyped.js)<Filter />
to<Table.Filter />
and used it as one of toolbaractions
Table.useFiltering
for these components