Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify search, TSify #3613

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Unify search, TSify #3613

merged 4 commits into from
Jul 31, 2023

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Jul 21, 2023

when searching from a bucket page, use global search and pre-select the bucket

TODO

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #3613 (f8eed84) into master (6743711) will increase coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
+ Coverage   36.09%   36.23%   +0.13%     
==========================================
  Files         674      673       -1     
  Lines       29688    29575     -113     
  Branches     4350     4327      -23     
==========================================
  Hits        10717    10717              
+ Misses      17813    17718      -95     
+ Partials     1158     1140      -18     
Flag Coverage Δ
api-python 91.35% <ø> (ø)
catalog 9.84% <0.00%> (+0.05%) ⬆️
lambda 86.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
catalog/app/components/SearchHelp.tsx 0.00% <0.00%> (ø)
catalog/app/constants/routes.js 0.00% <ø> (ø)
catalog/app/containers/App/App.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Bucket.js 0.00% <ø> (ø)
catalog/app/containers/Bucket/BucketNav.tsx 0.00% <ø> (ø)
catalog/app/containers/NavBar/Controls.js 0.00% <0.00%> (ø)
catalog/app/containers/NavBar/NavBar.tsx 0.00% <0.00%> (ø)
catalog/app/containers/NavBar/Search.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Search/Search.js 0.00% <0.00%> (ø)
...log/app/website/pages/OpenLanding/Search/Search.js 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nl0 nl0 marked this pull request as ready for review July 24, 2023 12:45
@nl0 nl0 requested a review from fiskus July 24, 2023 12:45
@nl0 nl0 changed the title Unify search Unify search, TSify Jul 24, 2023
fiskus
fiskus previously approved these changes Jul 24, 2023
@nl0 nl0 enabled auto-merge July 25, 2023 15:03
@nl0 nl0 added this pull request to the merge queue Jul 31, 2023
Merged via the queue into master with commit 0bf1e0b Jul 31, 2023
@nl0 nl0 deleted the unify-search branch July 31, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants