Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide columns without values in files listings #3512

Merged
merged 10 commits into from
Jul 5, 2023
Merged

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jun 26, 2023

  • Hide "modified date" column if empty. We can fix backend model separately ("Size" column is also hidden in directories without files)
  • Fixed text aligning for Size column in Packages tab

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3512 (a07fa43) into master (398e3fc) will increase coverage by 52.93%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3512       +/-   ##
===========================================
+ Coverage   36.15%   89.09%   +52.93%     
===========================================
  Files         675       79      -596     
  Lines       29705     9839    -19866     
  Branches     4350        0     -4350     
===========================================
- Hits        10740     8766     -1974     
+ Misses      17806     1073    -16733     
+ Partials     1159        0     -1159     
Flag Coverage Δ
api-python 91.22% <ø> (-0.13%) ⬇️
catalog ?
lambda 86.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 599 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus changed the title Hide modified column Hide columns without values in files listings Jun 26, 2023
@fiskus fiskus requested a review from nl0 June 26, 2023 11:11
nl0
nl0 previously approved these changes Jun 26, 2023
catalog/app/containers/Bucket/Listing.tsx Outdated Show resolved Hide resolved
@fiskus fiskus requested a review from nl0 July 4, 2023 12:30
@fiskus fiskus merged commit bcd862e into master Jul 5, 2023
@fiskus fiskus deleted the hide-modified-column branch July 5, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants