Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to documentation and re-use code samples #3496

Merged
merged 30 commits into from
Jun 21, 2023
Merged

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jun 14, 2023

Screenshot from 2023-06-14 14-37-24

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #3496 (4c77de5) into master (e1f0c5e) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3496      +/-   ##
==========================================
- Coverage   36.10%   36.04%   -0.06%     
==========================================
  Files         686      689       +3     
  Lines       29976    30020      +44     
  Branches     4418     4415       -3     
==========================================
  Hits        10822    10822              
- Misses      17982    18029      +47     
+ Partials     1172     1169       -3     
Flag Coverage Δ
api-python 91.35% <ø> (ø)
catalog 10.15% <0.00%> (-0.03%) ⬇️
lambda 86.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/CodeSamples/Code.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/CodeSamples/Dir.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/CodeSamples/File.tsx 0.00% <0.00%> (ø)
...alog/app/containers/Bucket/CodeSamples/Package.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Dir.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/File.js 0.00% <0.00%> (ø)
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% <0.00%> (ø)
catalog/app/embed/Dir.js 0.00% <0.00%> (ø)
catalog/app/embed/File.js 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 June 14, 2023 12:00
@fiskus fiskus changed the title Code samples: fix push syntax, add links to documentation and re-use samples Add links to documentation and re-use code samples Jun 16, 2023
nl0
nl0 previously approved these changes Jun 19, 2023
docs/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alexei Mochalov <[email protected]>
@fiskus fiskus requested a review from nl0 June 19, 2023 13:23
nl0
nl0 previously approved these changes Jun 19, 2023
@fiskus
Copy link
Member Author

fiskus commented Jun 20, 2023

Sorry, one small fix: removed --recursive for aws cp file code sample

catalog/app/containers/Bucket/CodeSamples/Dir.tsx Outdated Show resolved Hide resolved
catalog/app/containers/Bucket/File.js Outdated Show resolved Hide resolved
@fiskus fiskus requested a review from nl0 June 20, 2023 13:47
@fiskus fiskus merged commit 8839e2f into master Jun 21, 2023
@fiskus fiskus deleted the code-samples-revisit branch June 21, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants