Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter for Admin/Users and Admin/Buckets tables #3480

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jun 7, 2023

Screenshot from 2023-06-07 15-51-25

Screenshot from 2023-06-07 14-34-51

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #3480 (73ed088) into master (c8dba46) will decrease coverage by 52.93%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #3480       +/-   ##
===========================================
- Coverage   89.10%   36.17%   -52.93%     
===========================================
  Files          79      684      +605     
  Lines        9838    29910    +20072     
  Branches        0     4406     +4406     
===========================================
+ Hits         8766    10821     +2055     
- Misses       1072    17923    +16851     
- Partials        0     1166     +1166     
Flag Coverage Δ
api-python 91.35% <ø> (+0.12%) ⬆️
catalog 10.20% <0.00%> (?)
lambda 86.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Admin/Buckets/Buckets.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Filter.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Table.js 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Users/Users.js 0.00% <0.00%> (ø)

... and 604 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 June 7, 2023 12:57
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@fiskus fiskus merged commit e734abc into master Jun 7, 2023
@fiskus fiskus deleted the admin-users-buckets-filter branch June 7, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants