Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable gallery visibility #3421

Merged
merged 23 commits into from
May 10, 2023
Merged

Configurable gallery visibility #3421

merged 23 commits into from
May 10, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Apr 14, 2023

  • Moved image grids from Bucket/Overview.js and Bucket/Summary.js to Bucket/Gallery.tsx
  • Added ui.blocks.gallery to BucketPreferences
  • Migrate BucketPreferences to taggedV2 #3436 Used BucketPreferences.Result based on taggedV2 for async rendering
  • Documentation
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@fiskus fiskus changed the title Bucket prefs images Show/hide images grids Apr 14, 2023
@fiskus fiskus changed the title Show/hide images grids Configurable gallery visibility Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #3421 (46fb568) into master (d1df293) will decrease coverage by 0.04%.
The diff coverage is 5.35%.

@@            Coverage Diff             @@
##           master    #3421      +/-   ##
==========================================
- Coverage   36.22%   36.19%   -0.04%     
==========================================
  Files         682      683       +1     
  Lines       29787    29831      +44     
  Branches     4383     4394      +11     
==========================================
+ Hits        10790    10796       +6     
- Misses      17841    17875      +34     
- Partials     1156     1160       +4     
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 10.23% <5.35%> (+<0.01%) ⬆️
lambda 86.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/Gallery.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Meta.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Overview.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Summarize.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Summary.js 0.00% <0.00%> (ø)
.../app/containers/Bucket/requests/requestsUntyped.js 20.96% <33.33%> (+0.20%) ⬆️
...g/app/utils/BucketPreferences/BucketPreferences.ts 70.66% <50.00%> (-3.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus
Copy link
Member Author

fiskus commented Apr 20, 2023

BucketPreferences refactoring moved to #3436

@fiskus fiskus requested a review from nl0 May 2, 2023 21:04
nl0
nl0 previously approved these changes May 4, 2023
docs/Catalog/VisualizationDashboards.md Show resolved Hide resolved
@fiskus
Copy link
Member Author

fiskus commented May 5, 2023

Fixed some silly mistakes

@fiskus fiskus requested a review from nl0 May 5, 2023 10:13
@fiskus fiskus merged commit e206111 into master May 10, 2023
@fiskus fiskus deleted the bucket-prefs-images branch May 10, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants