Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Package.verify() raise exception when it have to compute unknown hash type #3401

Merged
merged 6 commits into from
May 2, 2023

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Apr 7, 2023

TODO

  • Unit tests
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@sir-sigurd sir-sigurd requested review from nl0 and dimaryaz April 7, 2023 11:05
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #3401 (ebb62f8) into master (590439d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3401      +/-   ##
==========================================
+ Coverage   36.09%   36.16%   +0.06%     
==========================================
  Files         680      680              
  Lines       29707    29735      +28     
  Branches     4390     4390              
==========================================
+ Hits        10724    10753      +29     
+ Misses      17830    17829       -1     
  Partials     1153     1153              
Flag Coverage Δ
api-python 91.29% <100.00%> (+0.05%) ⬆️
catalog 10.06% <ø> (ø)
lambda 86.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/python/quilt3/packages.py 93.40% <100.00%> (+0.16%) ⬆️
api/python/tests/integration/test_packages.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

nl0
nl0 previously approved these changes Apr 7, 2023
@robnewman robnewman requested a review from akarve April 26, 2023 14:26
@sir-sigurd sir-sigurd requested a review from robnewman May 1, 2023 13:15
@sir-sigurd sir-sigurd marked this pull request as ready for review May 2, 2023 10:27
@sir-sigurd sir-sigurd requested a review from nl0 May 2, 2023 10:27
nl0
nl0 previously approved these changes May 2, 2023
@sir-sigurd sir-sigurd dismissed robnewman’s stale review May 2, 2023 10:56

feedback is addressed

@sir-sigurd sir-sigurd merged commit e263fa3 into master May 2, 2023
@sir-sigurd sir-sigurd deleted the unknown-hash-exception branch May 2, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants