Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render status report if no bucketConfig #3396

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Render status report if no bucketConfig #3396

merged 2 commits into from
Apr 4, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Apr 4, 2023 •
edited
Loading

I don't know why, but there is no bucketConfig for bucket with status reports

@fiskus fiskus changed the title Render status report if no bucketconfig Render status report if no bucketConfig Apr 4, 2023
@fiskus fiskus requested a review from nl0 April 4, 2023 09:13
@nl0
Copy link
Member

nl0 commented Apr 4, 2023

I don't know why, but there is no bucketConfig for bucket with status reports

bucketConfig corresponds to the underlying Bucket db model, and for utility buckets we don't have those

@codecov
Copy link

codecov bot commented Apr 4, 2023 •
edited
Loading

Codecov Report

Merging #3396 (3bb7384) into master (62d6f8c) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #3396   +/-   ##
=======================================
  Coverage   35.04%   35.04%           
=======================================
  Files         679      679           
  Lines       29573    29573           
  Branches     4400     4400           
=======================================
  Hits        10364    10364           
  Misses      18016    18016           
  Partials     1193     1193
Flag Coverage Δ
api-python 90.80% <ø> (ø)
catalog 8.87% <0.00%> (ø)
lambda 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Preview/loaders/Html.js 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus merged commit b10ce17 into master Apr 4, 2023
@fiskus fiskus deleted the status-report-bucket-config branch April 4, 2023 13:15
nl0 added a commit that referenced this pull request Apr 6, 2023
@nl0
Merge branch 'master' into adjust-gql-error-handling
081914a 
* master:
  Add AnnData as format (#2974)
  Add unit tests for selector_fn (#3394)
  Quilt3 v5.2.1 (#3399)
  Render status report if no `bucketConfig` (#3396)
  Fix CSV serialization with pandas 2 (#3395)
robnewman pushed a commit that referenced this pull request Apr 6, 2023
@fiskus
Render status report if no bucketConfig (#3396)
f9124c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nl0 nl0 nl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiskus @nl0