Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation to enable Package Files Server #3388

Merged
merged 7 commits into from
Mar 27, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Mar 27, 2023

Screenshot from 2023-03-27 19-45-15

@fiskus fiskus changed the title Confirmation for enable Package Files Server Confirmation to enable Package Files Server Mar 27, 2023
@fiskus fiskus requested review from robnewman and nl0 March 27, 2023 16:49
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #3388 (86c088a) into master (0b8c475) will decrease coverage by 8.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3388      +/-   ##
==========================================
- Coverage   35.07%   27.04%   -8.04%     
==========================================
  Files         679      634      -45     
  Lines       29542    25555    -3987     
  Branches     4397     4405       +8     
==========================================
- Hits        10363     6911    -3452     
+ Misses      17988    17453     -535     
  Partials     1191     1191              
Flag Coverage Δ
api-python 90.76% <ø> (-0.04%) ⬇️
catalog 8.89% <0.00%> (-0.01%) ⬇️
lambda ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Dialog/Confirm.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Buckets/Buckets.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Form.tsx 0.00% <ø> (ø)

... and 47 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@robnewman robnewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor text changes

catalog/app/containers/Admin/Buckets/Buckets.tsx Outdated Show resolved Hide resolved
@robnewman robnewman self-requested a review March 27, 2023 17:40
@fiskus
Copy link
Member Author

fiskus commented Mar 27, 2023

@nl0 I'm going to merge this with just Rob approval. If you have some feedback on this PR, I will address it with higher priority

@fiskus fiskus merged commit d4fb7e8 into master Mar 27, 2023
@fiskus fiskus deleted the enable-package-files-server-confirmation branch March 27, 2023 18:02
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

robnewman added a commit that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants