Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object level user meta #3337

Merged
merged 10 commits into from
Feb 24, 2023
Merged

Object level user meta #3337

merged 10 commits into from
Feb 24, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Feb 20, 2023

  • PR mostly consists of type refactoring, specified type for object-level metadata in model/index.ts and re-used everywhere
  • Small change in EditFileMeta, where I get only user_meta
  • Docs change is small, and it will be visibly small after Resolve lint issues in "Working with the Catalog" #3338 merge
  • Documentation
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #3337 (ec16c82) into master (3ff3f25) will increase coverage by 8.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3337      +/-   ##
==========================================
+ Coverage   27.28%   35.31%   +8.02%     
==========================================
  Files         626      671      +45     
  Lines       25288    29295    +4007     
  Branches     4338     4341       +3     
==========================================
+ Hits         6901    10346    +3445     
- Misses      17216    17777     +561     
- Partials     1171     1172       +1     
Flag Coverage Δ
api-python 90.79% <ø> (+0.03%) ⬆️
catalog 8.97% <0.00%> (-0.01%) ⬇️
lambda 86.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...p/containers/Bucket/PackageDialog/EditFileMeta.tsx 0.00% <0.00%> (ø)
...app/containers/Bucket/PackageDialog/FilesInput.tsx 0.00% <0.00%> (ø)
...og/app/containers/Bucket/PackageDialog/Uploads.tsx 0.00% <ø> (ø)
catalog/app/model/index.ts 0.00% <ø> (ø)
lambdas/s3select/tests/test_s3select.py 100.00% <0.00%> (ø)
lambdas/es/indexer/test/test_read_notebook.py 100.00% <0.00%> (ø)
lambdas/shared/t4_lambda_shared/utils.py 97.40% <0.00%> (ø)
lambdas/preview/src/t4_lambda_preview/__init__.py 98.23% <0.00%> (ø)
lambdas/es/indexer/__init__.py 100.00% <0.00%> (ø)
lambdas/s3hash/setup.py 0.00% <0.00%> (ø)
... and 41 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested review from nl0 and sir-sigurd February 20, 2023 21:04
nl0
nl0 previously approved these changes Feb 21, 2023
@fiskus
Copy link
Member Author

fiskus commented Feb 23, 2023

Reverted docs changes because related PR #3338 diverged significantly. So, I left only necessary changes in docs.

@fiskus fiskus requested a review from nl0 February 23, 2023 20:45
@fiskus fiskus merged commit 5dd8896 into master Feb 24, 2023
@fiskus fiskus deleted the object-level-user-meta branch February 24, 2023 12:41
robnewman pushed a commit that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants