Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File edit as text #3306

Merged
merged 10 commits into from
Jan 30, 2023
Merged

File edit as text #3306

merged 10 commits into from
Jan 30, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jan 30, 2023 •
edited
Loading

Main change is in FileEditor/loader.ts - detected type changed from single value to array

  • If there are multiple detected types to edit, then there is a menu to select which type to use
  • Refactored state, types stores detected type, editing converted from boolean (is editing or not) to file type (if editing then with what type)
  • Move state to separate module and re-used state type instead of creating type individually for every component
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Jan 30, 2023 •
edited
Loading

Codecov Report

Merging #3306 (dee8ec9) into master (d4d2c04) will decrease coverage by 0.03%.
The diff coverage is 1.28%.

@@            Coverage Diff             @@
##           master    #3306      +/-   ##
==========================================
- Coverage   35.26%   35.23%   -0.03%     
==========================================
  Files         668      669       +1     
  Lines       29266    29289      +23     
  Branches     4340     4346       +6     
==========================================
  Hits        10321    10321              
- Misses      17759    17782      +23     
  Partials     1186     1186
Flag Coverage Δ
api-python 90.79% <ø> (ø)
catalog 8.85% <1.28%> (-0.02%) ⬇️
lambda 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/FileEditor/Controls.tsx 0.00% <0.00%> (ø)
catalog/app/components/FileEditor/FileEditor.tsx 0.00% <0.00%> (ø)
catalog/app/components/FileEditor/State.tsx 0.00% <0.00%> (ø)
catalog/app/components/FileEditor/index.ts 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/File.js 0.00% <0.00%> (ø)
catalog/app/components/FileEditor/loader.ts 52.17% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 January 30, 2023 14:39
nl0
nl0 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@fiskus fiskus merged commit 2b92f7d into master Jan 30, 2023
@fiskus fiskus deleted the file-edit-as-text branch January 30, 2023 16:38
nl0 added a commit that referenced this pull request Feb 1, 2023
@nl0
Merge branch 'master' into iframe-browsing
ab35a98 
* master:
  Iconized/Collapsed variant of collaborators badges for mobile (#3307)
  Remove the SSO signup page (#3304)
  File edit as text (#3306)
  Update quilt3 in pkgpush lambda (#3303)
akarve pushed a commit that referenced this pull request Feb 11, 2023
@fiskus @akarve
File edit as text (#3306)
dc96be1
robnewman pushed a commit that referenced this pull request Apr 6, 2023
@fiskus
File edit as text (#3306)
c5f162c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nl0 nl0 nl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiskus @nl0