Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of package entries metadata #3286

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Jan 20, 2023

Description

TODO

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #3286 (ca5aec7) into master (3eb8566) will increase coverage by 53.44%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #3286       +/-   ##
===========================================
+ Coverage   35.32%   88.76%   +53.44%     
===========================================
  Files         671       79      -592     
  Lines       29310     9670    -19640     
  Branches     4341        0     -4341     
===========================================
- Hits        10353     8584     -1769     
+ Misses      17785     1086    -16699     
+ Partials     1172        0     -1172     
Flag Coverage Δ
api-python 90.67% <100.00%> (-0.13%) ⬇️
catalog ?
lambda 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/python/quilt3/workflows/__init__.py 99.49% <ø> (ø)
api/python/tests/test_workflows.py 100.00% <100.00%> (ø)
api/python/quilt3/util.py 81.91% <0.00%> (-1.37%) ⬇️
api/python/tests/test_data_transfer.py 99.24% <0.00%> (-0.76%) ⬇️
api/python/quilt3/data_transfer.py 81.56% <0.00%> (-0.15%) ⬇️
catalog/app/containers/UriResolver/index.ts
...g/app/website/components/Backgrounds/Backlight1.js
catalog/app/components/Preview/loaders/fileType.ts
...AndPolicies/gql/PolicyUpdateUnmanaged.generated.ts
catalog/app/containers/NavBar/Search.js
... and 587 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sir-sigurd sir-sigurd force-pushed the entries-meta-validation branch 2 times, most recently from aff9542 to 4edcab6 Compare January 25, 2023 14:41
Copy link
Contributor

@robnewman robnewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the schema name - otherwise all good!

docs/advanced-features/workflows.md Outdated Show resolved Hide resolved
robnewman
robnewman previously approved these changes Jan 25, 2023
nl0
nl0 previously approved these changes Jan 26, 2023
docs/CHANGELOG.md Show resolved Hide resolved
@sir-sigurd sir-sigurd dismissed stale reviews from nl0 and robnewman via 8d7f9f7 March 2, 2023 14:45
@sir-sigurd sir-sigurd requested a review from nl0 March 2, 2023 14:47
@sir-sigurd sir-sigurd merged commit e96df90 into master Mar 2, 2023
@sir-sigurd sir-sigurd deleted the entries-meta-validation branch March 2, 2023 16:56
robnewman pushed a commit that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants