Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User metadata on one line #3284

Merged
merged 18 commits into from
Jan 25, 2023
Merged

User metadata on one line #3284

merged 18 commits into from
Jan 25, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jan 19, 2023

  • Rendered user metadata in packages list on one line. So, now it's almost identical to the User metadata in revisions list.
  • Added option to put metadata on multiple lines

Screenshot from 2023-01-23 23-50-19

  • Documentation
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #3284 (7ba4e4f) into master (e66b80f) will decrease coverage by 0.01%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master    #3284      +/-   ##
==========================================
- Coverage   35.24%   35.24%   -0.01%     
==========================================
  Files         667      667              
  Lines       29283    29289       +6     
  Branches     4337     4343       +6     
==========================================
+ Hits        10320    10322       +2     
- Misses      17770    17774       +4     
  Partials     1193     1193              
Flag Coverage Δ
api-python 90.79% <ø> (ø)
catalog 8.85% <36.36%> (+<0.01%) ⬆️
lambda 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../app/containers/Bucket/PackageList/PackageList.tsx 0.00% <0.00%> (ø)
...g/app/utils/BucketPreferences/BucketPreferences.ts 77.04% <66.66%> (-0.54%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus marked this pull request as ready for review January 23, 2023 22:14
@fiskus fiskus requested a review from nl0 January 23, 2023 22:16
nl0
nl0 previously approved these changes Jan 24, 2023
@fiskus
Copy link
Member Author

fiskus commented Jan 25, 2023

Sorry, I forgot to add new key to JSON Schema

@fiskus fiskus requested a review from nl0 January 25, 2023 15:57
@fiskus fiskus merged commit e8aef5c into master Jan 25, 2023
@fiskus fiskus deleted the usermetadata-one-line branch January 25, 2023 16:13
robnewman pushed a commit that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants