Refactor control to switch file types; Add "Plain Text" and "Echarts" file types #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fiskus
commented
Dec 22, 2022
•
fiskus
commented
- Move data about available file types to loaders
- Refactor getting correct file type, and make loaders chain order insignificant
- Replace strings with constants
- Add "text" and "echarts"
- Unit tests
- Changelog entry (skip if change is not significant to end users, e.g. docs only)
Codecov Report
@@ Coverage Diff @@
## master #3240 +/- ##
==========================================
- Coverage 35.31% 35.16% -0.16%
==========================================
Files 663 665 +2
Lines 29006 29047 +41
Branches 4279 4277 -2
==========================================
- Hits 10243 10213 -30
- Misses 17580 17645 +65
- Partials 1183 1189 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fiskus
changed the title
nl0
previously approved these changes
Dec 26, 2022
|
Merged with master and resolved trivial conflict |
nl0
approved these changes
Dec 26, 2022
QuiltSimon
pushed a commit
that referenced
this pull request
Dec 28, 2022
commit bfebc79 Author: Maksim Chervonnyi <[email protected]> Date: Wed Dec 28 13:38:35 2022 +0300 Hotfix: summary file has no type (#3244) commit 092b3af Author: Maksim Chervonnyi <[email protected]> Date: Tue Dec 27 14:15:42 2022 +0300 Bug fix: Show `submitError` for Invite user form (#3239) commit d76c0c7 Author: Maksim Chervonnyi <[email protected]> Date: Tue Dec 27 14:04:21 2022 +0300 Refactor control to switch file types; Add "Plain Text" and "Echarts" file types (#3240) commit 63342d2 Author: Maksim Chervonnyi <[email protected]> Date: Mon Dec 26 16:34:35 2022 +0300 Fix hiding empty values for NGL Meta (#3241) commit 21c9bb3 Author: Alexei Mochalov <[email protected]> Date: Mon Dec 26 15:56:19 2022 +0500 Update config schema and usage (#3238) * add missing azure* and oneLogin* keys * remove deprecated binaryApiGatewayEndpoint * adjust config imports and related code * utils/Config: remove deprecated API commit d5766c1 Author: Maksim Chervonnyi <[email protected]> Date: Thu Dec 22 19:17:48 2022 +0300 Add help message to `tagged#case` to find out which variants are redundant (#3237) Co-authored-by: Alexei Mochalov <[email protected]> commit 21246e1 Author: Sergey Fedoseev <[email protected]> Date: Thu Dec 22 17:24:32 2022 +0400 Add missing tagging permission for cross-account setup (#3236) commit eedfdbc Author: Rob Newman <[email protected]> Date: Tue Dec 20 08:27:27 2022 -0800 Add section on known issues for Perspective (#3234) commit 135fc36 Author: Dima Ryazanov <[email protected]> Date: Mon Dec 19 11:45:54 2022 -0800 Bump mod_zip: allow empty zip files (#2991) See quiltdata/mod_zip@979314c Will make the registry code simpler. commit ea4d360 Author: Rob Newman <[email protected]> Date: Fri Dec 16 15:36:41 2022 -0800 Add XDG cache example python script (#3232) * Add XDG cache example python script * Add more details * Change cache path to be more realistic * Add link to AWS Lambda docs * Fix gendocs source * Add pytest.mark.skip * Remove misleading workaround * Don't forget gendocs generated file commit 53461a4 Author: Maksim Chervonnyi <[email protected]> Date: Fri Dec 16 15:41:08 2022 +0200 Add docs links to Athena query skeleton (#3230) commit 12e24d4 Author: Rob Newman <[email protected]> Date: Wed Dec 14 12:48:58 2022 -0800 Docs links to live packages on open (#3229) * Add links to IGV, Perspective, Vega live packages on open * Add link to new EChart data package on open commit 4f4b043 Author: Rob Newman <[email protected]> Date: Wed Dec 14 10:51:51 2022 -0800 Update example S3 bucket policy to include GetObjectTagging (#3228) commit c77236d Author: Sergey Fedoseev <[email protected]> Date: Wed Dec 14 21:17:36 2022 +0400 Update release docs (#3224) commit 9f50114 Author: Sergey Fedoseev <[email protected]> Date: Fri Dec 9 22:18:40 2022 +0400 Normalize case of HTTP headers names passed to lambdas (#3225) commit 0953bb4 Author: Sergey Fedoseev <[email protected]> Date: Fri Dec 9 13:37:37 2022 +0400 Quilt3 v5.1.0 (#3205) commit c17710c Author: Aneesh Karve <[email protected]> Date: Thu Dec 8 14:33:52 2022 -0700 Update pricing tiers, marketing site (#3208) commit 8f6e71e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 8 15:24:56 2022 +0500 Bump certifi from 2018.11.29 to 2022.12.7 in /lambdas/thumbnail (#3217) Bumps [certifi](https://github.com/certifi/python-certifi) from 2018.11.29 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2018.11.29...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergey Fedoseev <[email protected]> commit 1afee0e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 8 14:55:23 2022 +0500 Bump certifi from 2022.5.18.1 to 2022.12.7 in /lambdas/molecule (#3220) Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.5.18.1 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2022.05.18.1...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergey Fedoseev <[email protected]> commit 6842c29 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 8 14:42:35 2022 +0500 Bump certifi from 2020.4.5.1 to 2022.12.7 in /lambdas/preview (#3221) Bumps [certifi](https://github.com/certifi/python-certifi) from 2020.4.5.1 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2020.04.05.1...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergey Fedoseev <[email protected]> commit 3755c59 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 8 14:10:32 2022 +0500 Bump certifi from 2022.6.15 to 2022.12.7 in /testdocs (#3223) Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.6.15 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2022.06.15...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6c72177 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 8 13:58:33 2022 +0500 Bump certifi from 2021.10.8 to 2022.12.7 in /lambdas/tabular_preview (#3222) Bumps [certifi](https://github.com/certifi/python-certifi) from 2021.10.8 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2021.10.08...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 595b9f7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 8 13:38:51 2022 +0500 Bump certifi from 2019.6.16 to 2022.12.7 in /lambdas/es/indexer (#3219) Bumps [certifi](https://github.com/certifi/python-certifi) from 2019.6.16 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2019.06.16...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit fbb8262 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 8 13:17:33 2022 +0500 Bump certifi from 2019.6.16 to 2022.12.7 in /lambdas/s3select (#3218) Bumps [certifi](https://github.com/certifi/python-certifi) from 2019.6.16 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2019.06.16...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergey Fedoseev <[email protected]> commit 58e23d4 Author: Sergey Fedoseev <[email protected]> Date: Thu Dec 8 12:03:19 2022 +0400 Reorder latest changelog entries (#3215) commit 363680f Author: Dima Ryazanov <[email protected]> Date: Mon Dec 5 15:32:24 2022 -0800 Add an API changelog entry for the dedupe parameter (#3190) commit 2bb9b2a Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Dec 2 20:09:32 2022 +0500 Update dependency ts-loader to ^9.4.2 (#3214) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 350265a Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Dec 2 19:51:45 2022 +0500 Update sentry-javascript monorepo to ^7.23.0 (#3213) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 12eed96 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Dec 2 19:26:33 2022 +0500 Update dependency react-router-dom to ^5.3.4 (#3212) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 018cecd Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Dec 2 19:05:06 2022 +0500 Update dependency express to ^4.18.2 (#3211) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 2a5eb3e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Dec 2 18:47:01 2022 +0500 Update dependency ajv to ^8.11.2 (#3210) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit fb75f61 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Dec 2 18:21:49 2022 +0500 Update dependency loglevel to ^1.8.1 (#3209) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit a5676cd Author: Sergey Fedoseev <[email protected]> Date: Tue Nov 29 19:48:20 2022 +0300 Remove docs section from changelog (#3207) commit c2ca528 Author: Aneesh Karve <[email protected]> Date: Tue Nov 29 08:36:32 2022 -0800 Specify that the changelog is not for docs (#3188) commit 964082d Author: Sergey Fedoseev <[email protected]> Date: Tue Nov 29 15:02:06 2022 +0300 Reorder latest changelog entries (#3206) commit 95adde3 Author: Sergey Fedoseev <[email protected]> Date: Mon Nov 28 20:25:43 2022 +0300 Document ordering of changelog entries by type (#3204)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.