Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata expanded #3175

Merged
merged 14 commits into from
Nov 9, 2022
Merged

Metadata expanded #3175

merged 14 commits into from
Nov 9, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Nov 7, 2022

  • Added options to ui.blocks.meta. User can set object instead of boolean: { user_meta: { expanded: true }, workflows: expanded: true }
  • Refactored BucketPreferences.ts: added AsyncResult to return value. Used only in new code yet (Copied from Added ui.search.mode to .quilt/catalog/config.yaml #3129)

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #3175 (dd78cbc) into master (0b666e6) will increase coverage by 0.00%.
The diff coverage is 19.51%.

@@           Coverage Diff           @@
##           master    #3175   +/-   ##
=======================================
  Coverage   35.00%   35.01%           
=======================================
  Files         661      661           
  Lines       28985    29005   +20     
  Branches     4263     4272    +9     
=======================================
+ Hits        10147    10155    +8     
- Misses      17650    17662   +12     
  Partials     1188     1188           
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.32% <19.51%> (+0.03%) ⬆️
lambda 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/BucketNav.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Dir.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/File.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Meta.tsx 0.00% <0.00%> (ø)
...iners/Bucket/PackageDialog/PackageCreationForm.tsx 0.00% <0.00%> (ø)
.../app/containers/Bucket/PackageList/PackageList.tsx 0.00% <0.00%> (ø)
...iners/Bucket/PackageRevisions/PackageRevisions.tsx 0.00% <0.00%> (ø)
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% <0.00%> (ø)
...app/containers/Bucket/PackageTree/RevisionMenu.tsx 0.00% <0.00%> (ø)
...g/app/containers/Bucket/Queries/requests/athena.ts 0.00% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 November 7, 2022 20:53
@fiskus fiskus merged commit 933e3e2 into master Nov 9, 2022
@fiskus fiskus deleted the metadata-expanded branch November 9, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants