Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to platformdirs #3140

Merged
merged 10 commits into from
Oct 20, 2022
Merged

Switch to platformdirs #3140

merged 10 commits into from
Oct 20, 2022

Conversation

flying-sheep
Copy link
Collaborator

@flying-sheep flying-sheep commented Oct 13, 2022

Description

See https://github.com/platformdirs/platformdirs#why-this-fork:

Why this Fork?

This repository is a friendly fork of the wonderful work started by ActiveState who created appdirs, this package's ancestor.

Maintaining an open source project is no easy task, particularly from within an organization, and the Python community is indebted to appdirs (and to Trent Mick and Jeff Rouse in particular) for creating an incredibly useful simple module, as evidenced by the wide number of users it has attracted over the years.

Nonetheless, given the number of long-standing open issues and pull requests, and no clear path towards ActiveState/appdirs#79, this fork was created.

Contributions are most welcome.

TODO

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #3140 (93ae983) into master (7f60ebd) will increase coverage by 53.77%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #3140       +/-   ##
===========================================
+ Coverage   35.00%   88.78%   +53.77%     
===========================================
  Files         651       79      -572     
  Lines       28695     9620    -19075     
  Branches     4207        0     -4207     
===========================================
- Hits        10045     8541     -1504     
+ Misses      17466     1079    -16387     
+ Partials     1184        0     -1184     
Flag Coverage Δ
api-python 90.72% <100.00%> (+<0.01%) ⬆️
catalog ?
lambda 86.05% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/python/setup.py 0.00% <ø> (ø)
api/python/tests/integration/test_packages.py 100.00% <ø> (ø)
api/python/quilt3/util.py 83.27% <100.00%> (ø)
api/python/tests/conftest.py 92.59% <100.00%> (+0.43%) ⬆️
catalog/app/containers/NavBar/NavBar.tsx
catalog/app/components/Pagination/Controls.js
catalog/app/utils/HashLink.js
catalog/app/utils/Okta.js
catalog/app/website/pages/Install/index.js
catalog/app/components/Pagination/index.js
... and 570 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sir-sigurd sir-sigurd self-requested a review October 18, 2022 12:12
api/python/setup.py Outdated Show resolved Hide resolved
api/python/tests/conftest.py Show resolved Hide resolved
api/python/setup.py Outdated Show resolved Hide resolved
@sir-sigurd sir-sigurd merged commit 1a823de into quiltdata:master Oct 20, 2022
@sir-sigurd
Copy link
Member

@flying-sheep, thanks!

@flying-sheep flying-sheep deleted the platformdirs branch October 21, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants