Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package create file #3127

Merged
merged 6 commits into from
Oct 10, 2022
Merged

Package create file #3127

merged 6 commits into from
Oct 10, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Oct 6, 2022

  • Move code related to code creation to components/FileEditor
  • Add "Create file" item to package revision menu and configure URLs for file creation and back adding file to package

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #3127 (1a9cfa2) into master (13e22c0) will decrease coverage by 0.59%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3127      +/-   ##
==========================================
- Coverage   35.40%   34.80%   -0.60%     
==========================================
  Files         648      644       -4     
  Lines       28620    28366     -254     
  Branches     4189     4187       -2     
==========================================
- Hits        10132     9873     -259     
- Misses      17308    17313       +5     
  Partials     1180     1180              
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.37% <0.00%> (-0.01%) ⬇️
lambda 85.48% <ø> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/FileEditor/CreateFile.tsx 0.00% <0.00%> (ø)
catalog/app/components/FileEditor/index.ts 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Dir.tsx 0.00% <0.00%> (ø)
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% <0.00%> (ø)
...app/containers/Bucket/PackageTree/RevisionMenu.tsx 0.00% <0.00%> (ø)
lambdas/shared/t4_lambda_shared/utils.py 94.80% <0.00%> (-2.60%) ⬇️
lambdas/access_counts/index.py
lambdas/pkgevents/tests/test_index.py
lambdas/pkgevents/tests/conftest.py
lambdas/pkgevents/index.py
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 October 7, 2022 18:47
@fiskus fiskus merged commit edf30b0 into master Oct 10, 2022
@fiskus fiskus deleted the package-create-file branch October 10, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants