Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena: Remove duplicate first row #3101

Merged
merged 5 commits into from
Sep 26, 2022
Merged

Athena: Remove duplicate first row #3101

merged 5 commits into from
Sep 26, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Sep 23, 2022

Practically found that first row have column names always, but didn't find that in documentation or on StackOverflow (only questions on how to skip first row when create table)

  • So, I check if first row have column names, then skip. I have dedicated columns field already
  • Replaced use of first row for checking if table have package manifest with use of columns

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #3101 (86cf269) into master (cde94d0) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3101      +/-   ##
==========================================
- Coverage   35.33%   35.33%   -0.01%     
==========================================
  Files         642      642              
  Lines       28451    28454       +3     
  Branches     4160     4161       +1     
==========================================
  Hits        10053    10053              
- Misses      17224    17227       +3     
  Partials     1174     1174              
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.04% <0.00%> (-0.01%) ⬇️
lambda 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...og/app/containers/Bucket/Queries/Athena/Athena.tsx 0.00% <0.00%> (ø)
...containers/Bucket/Queries/Athena/CreatePackage.tsx 0.00% <0.00%> (ø)
...g/app/containers/Bucket/Queries/requests/athena.ts 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus changed the title Athena duplicates Athena: Remove duplicate first row Sep 26, 2022
@fiskus fiskus requested a review from nl0 September 26, 2022 15:04
@fiskus fiskus merged commit 2c622d5 into master Sep 26, 2022
@fiskus fiskus deleted the athena-duplicates branch September 26, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants