Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine status reports design #3088

Merged
merged 5 commits into from
Sep 15, 2022
Merged

Refine status reports design #3088

merged 5 commits into from
Sep 15, 2022

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Sep 14, 2022

TODO

@nl0
Copy link
Member Author

nl0 commented Sep 14, 2022

@sir-sigurd do i need to change anything (in setup.py?) for template files to be included into the package?

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #3088 (27af827) into master (2a7ad47) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #3088      +/-   ##
==========================================
- Coverage   35.49%   35.49%   -0.01%     
==========================================
  Files         641      641              
  Lines       28319    28320       +1     
  Branches     4131     4131              
==========================================
  Hits        10053    10053              
- Misses      17090    17091       +1     
  Partials     1176     1176              
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.10% <ø> (ø)
lambda 86.05% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s_reports/src/t4_lambda_status_reports/__init__.py 30.33% <33.33%> (-0.35%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sir-sigurd
Copy link
Member

@sir-sigurd do i need to change anything (in setup.py?) for template files to be included into the package?

I think you need to add it to MANIFEST.in and enable include_package_data, see

include LICENSE
include quilt3/VERSION
include quilt3/workflows/*.schema.json

and
include_package_data=True,

for example.

You should also try to deploy lambda with our deploy script because it tries to remove some useless stuff, but probably can remove useful stuff as well.

@nl0
Copy link
Member Author

nl0 commented Sep 15, 2022

@sir-sigurd do i need to change anything (in setup.py?) for template files to be included into the package?

I think you need to add it to MANIFEST.in and enable include_package_data, see

include LICENSE
include quilt3/VERSION
include quilt3/workflows/*.schema.json

and

include_package_data=True,

for example.

You should also try to deploy lambda with our deploy script because it tries to remove some useless stuff, but probably can remove useful stuff as well.

that worked, thanks

@nl0
Copy link
Member Author

nl0 commented Sep 15, 2022

@sir-sigurd pls have a look

@nl0 nl0 merged commit e39dc3d into master Sep 15, 2022
@nl0 nl0 deleted the refine-report-design branch September 15, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants