Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-popullation of default dates when using "dateformat" + {"format": "date"} #3082

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Sep 9, 2022

Pre-filling dates was happened during final validation on package submit but not during validation on form change. Fixed this

Also, re-used function for getting default value with "workaround" for "dateformat" field

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #3082 (1948b8e) into master (2db5e08) will increase coverage by 53.31%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3082       +/-   ##
===========================================
+ Coverage   35.47%   88.78%   +53.31%     
===========================================
  Files         641       79      -562     
  Lines       28327     9616    -18711     
  Branches     4132        0     -4132     
===========================================
- Hits        10049     8538     -1511     
+ Misses      17096     1078    -16018     
+ Partials     1182        0     -1182     
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog ?
lambda 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/JsonEditor/State.js
.../containers/Bucket/PackageDialog/PackageDialog.tsx
...ntainers/Admin/Buckets/gql/BucketsAdd.generated.ts
...app/containers/Admin/RolesAndPolicies/Policies.tsx
catalog/app/components/Preview/loaders/Json.js
...og/app/containers/Bucket/Queries/requests/index.ts
catalog/app/embed/File.js
catalog/app/embed/Dir.js
catalog/app/containers/Admin/Status/DataGrid.ts
catalog/app/utils/voila.ts
... and 552 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus changed the title Json editor dateformat pre fill Fix pre-popullation of default dates when using "dateformat" + {"format": "date"} Sep 12, 2022
@fiskus fiskus requested a review from nl0 September 12, 2022 14:18
@fiskus fiskus merged commit e7b5eeb into master Sep 12, 2022
@fiskus fiskus deleted the json-editor-dateformat-pre-fill branch September 12, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants