-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer revision hash #3074
Footer revision hash #3074
Conversation
fiskus
commented
Sep 6, 2022
•
edited
Loading
edited
Codecov Report
@@ Coverage Diff @@
## master #3074 +/- ##
==========================================
+ Coverage 33.39% 35.47% +2.07%
==========================================
Files 634 641 +7
Lines 27384 28327 +943
Branches 4132 4132
==========================================
+ Hits 9146 10049 +903
- Misses 17056 17096 +40
Partials 1182 1182
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code looks ok, but im not sure about the design. i think this plain hash string may look kinda random / suspicious to some not very technical customer. maybe we can add some description to it and show several first characters of the hash, e.g. make it look like Revision: 1d54afcb
, and remove the copy button, just copy the full hash on click
and maybe use "product revision" language instead of "version" in tooltips and notifications |
Agreed Changed layout |