Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer revision hash #3074

Merged
merged 9 commits into from
Sep 12, 2022
Merged

Footer revision hash #3074

merged 9 commits into from
Sep 12, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Sep 6, 2022

Screenshot from 2022-09-12 12-57-14

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #3074 (62739aa) into master (c523867) will increase coverage by 2.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3074      +/-   ##
==========================================
+ Coverage   33.39%   35.47%   +2.07%     
==========================================
  Files         634      641       +7     
  Lines       27384    28327     +943     
  Branches     4132     4132              
==========================================
+ Hits         9146    10049     +903     
- Misses      17056    17096      +40     
  Partials     1182     1182              
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.07% <0.00%> (-0.01%) ⬇️
lambda 86.07% <ø> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Footer/Footer.js 0.00% <0.00%> (ø)
lambdas/pkgpush/src/t4_lambda_pkgpush/__init__.py 94.09% <0.00%> (ø)
lambdas/s3select/tests/test_s3select.py 100.00% <0.00%> (ø)
lambdas/pkgpush/tests/test_index.py 100.00% <0.00%> (ø)
lambdas/access_counts/index.py 86.36% <0.00%> (ø)
lambdas/access_counts/tests/test_access_counts.py 100.00% <0.00%> (ø)
lambdas/pkgpush/tests/conftest.py 100.00% <0.00%> (ø)
...ambdas/s3select/src/t4_lambda_s3select/__init__.py 100.00% <0.00%> (ø)
lambdas/shared/t4_lambda_shared/utils.py 97.40% <0.00%> (+2.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus marked this pull request as ready for review September 8, 2022 11:45
@fiskus fiskus requested a review from nl0 September 8, 2022 11:45
nl0
nl0 previously approved these changes Sep 12, 2022
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks ok, but im not sure about the design. i think this plain hash string may look kinda random / suspicious to some not very technical customer. maybe we can add some description to it and show several first characters of the hash, e.g. make it look like Revision: 1d54afcb, and remove the copy button, just copy the full hash on click

@nl0
Copy link
Member

nl0 commented Sep 12, 2022

and maybe use "product revision" language instead of "version" in tooltips and notifications

@fiskus
Copy link
Member Author

fiskus commented Sep 12, 2022

Agreed

Changed layout

@fiskus fiskus requested a review from nl0 September 12, 2022 09:58
@fiskus fiskus merged commit 2db5e08 into master Sep 12, 2022
@fiskus fiskus deleted the footer-revision-hash branch September 12, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants