Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit file and add to package #3070

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Edit file and add to package #3070

merged 5 commits into from
Sep 12, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Sep 5, 2022

Screenshot from 2022-09-12 18-15-22

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #3070 (79be411) into master (2db5e08) will decrease coverage by 26.14%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##           master   #3070       +/-   ##
==========================================
- Coverage   35.47%   9.33%   -26.15%     
==========================================
  Files         641     578       -63     
  Lines       28327   19529     -8798     
  Branches     4132    4135        +3     
==========================================
- Hits        10049    1823     -8226     
+ Misses      17096   16524      -572     
  Partials     1182    1182               
Flag Coverage Δ
api-python ?
catalog 8.06% <43.75%> (-0.01%) ⬇️
lambda 38.49% <ø> (-47.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Summary.js 0.00% <ø> (ø)
catalog/app/components/JsonEditor/State.js 61.87% <100.00%> (+0.33%) ⬆️
.../containers/Bucket/PackageDialog/PackageDialog.tsx 26.61% <100.00%> (+0.29%) ⬆️
lambdas/transcode/index.py 0.00% <0.00%> (-97.92%) ⬇️
lambdas/transcode/tests/test_transcode.py 0.00% <0.00%> (-94.12%) ⬇️
lambdas/shared/t4_lambda_shared/utils.py 36.36% <0.00%> (-61.04%) ⬇️
lambdas/pkgselect/index.py 0.00% <0.00%> (-33.34%) ⬇️
lambdas/pkgselect/test/test_pkgselect.py 0.00% <0.00%> (-13.98%) ⬇️
lambdas/es/indexer/index.py
... and 62 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus marked this pull request as draft September 6, 2022 07:44
@fiskus fiskus marked this pull request as ready for review September 12, 2022 15:11
@fiskus fiskus requested a review from nl0 September 12, 2022 15:24
@fiskus fiskus merged commit 6ec1877 into master Sep 12, 2022
@fiskus fiskus deleted the edit-package-file branch September 12, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants