Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Reports UI #3068

Merged
merged 7 commits into from
Sep 7, 2022
Merged

Status Reports UI #3068

merged 7 commits into from
Sep 7, 2022

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Sep 1, 2022

Description

Add status reports datagrid (sortable, filterable, paginated) to admin/status screen (plus related graphql changes and some utility adjustments):

Screenshot 2022-09-02 at 15 15 48

TODO

Depends on related registry / lambda / deployment changes (tho should gracefully degrade even without them)

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #3068 (5bf8c1c) into master (bb05b83) will decrease coverage by 0.14%.
The diff coverage is 3.14%.

@@            Coverage Diff             @@
##           master    #3068      +/-   ##
==========================================
- Coverage   35.63%   35.49%   -0.15%     
==========================================
  Files         634      641       +7     
  Lines       28155    28315     +160     
  Branches     4100     4134      +34     
==========================================
+ Hits        10032    10049      +17     
- Misses      16949    17084     +135     
- Partials     1174     1182       +8     
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.08% <3.14%> (+0.02%) ⬆️
lambda 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Preview/loaders/Html.js 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Status/Canaries.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Status/DataGrid.ts 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Status/Reports.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Status/Stats.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Status/Status.tsx 0.00% <0.00%> (ø)
...p/containers/Admin/Status/gql/Reports.generated.ts 0.00% <0.00%> (ø)
...pp/containers/Admin/Status/gql/Status.generated.ts 0.00% <ø> (ø)
catalog/app/model/graphql/schema.generated.ts 0.00% <ø> (ø)
catalog/app/model/graphql/types.generated.ts 0.00% <0.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nl0 nl0 marked this pull request as ready for review September 2, 2022 10:20
@nl0 nl0 requested a review from fiskus September 2, 2022 10:21
fiskus
fiskus previously approved these changes Sep 2, 2022
catalog/app/model/S3.ts Show resolved Hide resolved
fiskus
fiskus previously approved these changes Sep 5, 2022
fiskus
fiskus previously approved these changes Sep 5, 2022
@nl0 nl0 merged commit cf8e8e5 into master Sep 7, 2022
@nl0 nl0 deleted the status-reports-admin branch September 7, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants