Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create text file #3017

Merged
merged 23 commits into from
Aug 29, 2022
Merged

Create text file #3017

merged 23 commits into from
Aug 29, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 24, 2022

  • Refactored component for showing menu (RevisionMenu) and re-used it on bucket directory page
  • Added custom prompt component using M.Dialog
  • Prompt for file name and redirect to file editor

Screenshot from 2022-08-25 20-01-17
Screenshot from 2022-08-25 20-01-48
Screenshot from 2022-08-25 20-02-03

TODO

  • Documentation (in the next clean PR, with Ernie help, probably)
  • Changelog entry

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #3017 (16ee9d5) into master (9d9e827) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3017      +/-   ##
==========================================
- Coverage   35.72%   35.65%   -0.08%     
==========================================
  Files         627      630       +3     
  Lines       27968    28028      +60     
  Branches     4078     4081       +3     
==========================================
  Hits         9992     9992              
- Misses      16808    16864      +56     
- Partials     1168     1172       +4     
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.04% <0.00%> (-0.03%) ⬇️
lambda 87.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Dialog/Prompt.tsx 0.00% <0.00%> (ø)
catalog/app/components/Dialog/index.ts 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Dir.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/FileView.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Menu.tsx 0.00% <0.00%> (ø)
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% <ø> (ø)
...app/containers/Bucket/PackageTree/RevisionMenu.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Successors.tsx 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 August 25, 2022 19:58
nl0
nl0 previously approved these changes Aug 26, 2022
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some suggestions inline.
also, does it work for creating nested files (i.e. if i type smth like prefix/file.md into the prompt)?

catalog/app/components/Dialog/Prompt.tsx Outdated Show resolved Hide resolved
catalog/app/components/Dialog/Prompt.tsx Show resolved Hide resolved
@fiskus
Copy link
Member Author

fiskus commented Aug 26, 2022

also, does it work for creating nested files (i.e. if i type smth like prefix/file.md into the prompt)?

Yes, it works, but I don't want to advertise this "feature" yet. I want to come up with some nicer way of creating folders (if it's possible to create a folder without a file in it).

@fiskus fiskus requested a review from nl0 August 26, 2022 13:53
@fiskus fiskus merged commit c427c93 into master Aug 29, 2022
@fiskus fiskus deleted the create-text-file branch August 29, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants