Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena to packages #3004

Merged
merged 22 commits into from
Aug 24, 2022
Merged

Athena to packages #3004

merged 22 commits into from
Aug 24, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 22, 2022

Sample table view is in /b/fiskus-sandbox-dev/queries/athena/fiskus-test/db3f6700-906c-434d-9119-ee18b4880e0b on searchminimal stack

Screenshot from 2022-08-24 13-55-28

Screenshot from 2022-08-24 13-55-38

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #3004 (77dd9e4) into master (75deb0b) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
- Coverage   35.80%   35.72%   -0.08%     
==========================================
  Files         626      627       +1     
  Lines       27906    27968      +62     
  Branches     4060     4078      +18     
==========================================
  Hits         9992     9992              
- Misses      16752    16808      +56     
- Partials     1162     1168       +6     
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.07% <0.00%> (-0.03%) ⬇️
lambda 87.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Code/Code.tsx 0.00% <0.00%> (ø)
...og/app/containers/Bucket/Queries/Athena/Athena.tsx 0.00% <0.00%> (ø)
...containers/Bucket/Queries/Athena/CreatePackage.tsx 0.00% <0.00%> (ø)
...g/app/containers/Bucket/Queries/Athena/History.tsx 0.00% <0.00%> (ø)
...g/app/containers/Bucket/Queries/requests/athena.ts 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 August 24, 2022 11:00
nl0
nl0 previously approved these changes Aug 24, 2022
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good sans some typos

@fiskus fiskus requested a review from nl0 August 24, 2022 14:59
@fiskus fiskus merged commit 0837f1d into master Aug 24, 2022
@fiskus fiskus deleted the athena-to-packages branch August 24, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants