Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy athena query #2993

Merged
merged 8 commits into from
Aug 22, 2022
Merged

Copy athena query #2993

merged 8 commits into from
Aug 22, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 18, 2022

Description

Screenshot from 2022-08-18 23-22-53
Screenshot from 2022-08-18 23-23-05

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #2993 (06a780d) into master (e92eabd) will increase coverage by 0.73%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2993      +/-   ##
==========================================
+ Coverage   35.09%   35.82%   +0.73%     
==========================================
  Files         623      626       +3     
  Lines       27581    27877     +296     
  Branches     4065     4059       -6     
==========================================
+ Hits         9679     9988     +309     
+ Misses      16742    16727      -15     
- Partials     1160     1162       +2     
Flag Coverage Δ
api-python 90.71% <ø> (ø)
catalog 8.10% <0.00%> (-0.01%) ⬇️
lambda 87.29% <ø> (+1.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/app/containers/Bucket/Queries/Athena/History.tsx 0.00% <0.00%> (ø)
lambdas/shared/tests/test_decorator.py 100.00% <0.00%> (ø)
lambdas/shared/tests/test_preview.py 100.00% <0.00%> (ø)
lambdas/shared/tests/test_utils.py 97.29% <0.00%> (ø)
lambdas/shared/t4_lambda_shared/decorator.py 91.54% <0.00%> (+1.40%) ⬆️
lambdas/shared/t4_lambda_shared/preview.py 98.52% <0.00%> (+2.94%) ⬆️
lambdas/shared/t4_lambda_shared/utils.py 97.40% <0.00%> (+33.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 August 19, 2022 16:02
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, i don't see anything suspicious

@fiskus fiskus merged commit 47fdb62 into master Aug 22, 2022
@fiskus fiskus deleted the athena-copy-query branch August 22, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants