Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove idempotency token for Athena queries #2992

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 18, 2022

Description

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Documentation
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
  • Changelog entry

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #2992 (066affb) into master (4f84147) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2992      +/-   ##
==========================================
+ Coverage   38.79%   38.81%   +0.01%     
==========================================
  Files         623      623              
  Lines       27635    27621      -14     
  Branches     4013     4008       -5     
==========================================
  Hits        10720    10720              
+ Misses      15770    15757      -13     
+ Partials     1145     1144       -1     
Flag Coverage Δ
api-python 90.71% <ø> (ø)
catalog 12.26% <ø> (+<0.01%) ⬆️
lambda 87.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/app/containers/Bucket/Queries/requests/athena.ts 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus changed the title remove idempotency for Athena queries Remove idempotency token for Athena queries Aug 18, 2022
@fiskus fiskus requested review from nl0 and akarve August 18, 2022 19:39
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this change? is idempotency useless in this case?

@fiskus
Copy link
Member Author

fiskus commented Aug 19, 2022

Documentation is a little confusing: it says that two requests with the same token will return the same query. It doesn't say about results. So, probably it means two simultaneously executed queries will execute only one query if they share the same token. But it seems it's already done internally by SDK, and this token is not required (they articulate it in docs, that it's not required)
And preserving this token in code can lead to bugs, and it's just unnecessary to maintain something we don't need.


TLDR:

  1. It's not required
  2. It can produce errors and additional work to maintain

@fiskus fiskus merged commit 980dc06 into master Aug 19, 2022
@fiskus fiskus deleted the athena-remove-idempotency branch August 19, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants