Test quilt3 on Win on all Python versions #2900
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2900 +/- ##
=======================================
Coverage 39.95% 39.95%
=======================================
Files 593 593
Lines 26870 26870
Branches 3889 3889
=======================================
Hits 10736 10736
Misses 15015 15015
Partials 1119 1119
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
| @@ -1462,7 +1462,7 @@ def check_latest_hash(): | |||
| def physical_key_is_temp_file(pk): | |||
| if not pk.is_local(): | |||
| return False | |||
| return pathlib.Path(pk.path).parent == APP_DIR_TEMPFILE_DIR | |||
| return pathlib.Path(pk.path).parent.resolve() == APP_DIR_TEMPFILE_DIR.resolve() | |||
There was a problem hiding this comment.
Does it make sense to do this normalization when we create PhysicalKey instances?
There was a problem hiding this comment.
Maybe but I'd suggest a separate PR as there's more risk in changing the PhysicalKey interface, which isn't broken so we should be careful fixing it :)
There was a problem hiding this comment.
I'd agree with both of those points. In theory, the resolution should not have a problematic effect -- but knowing definitively is another matter.
PR #2900, Test Quilt3 on Win on all Python versions
Description
Cleaner redo of #2861 after incorrect rebase.
TODO
build.pyfor new docstrings