Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perspective restore() config #2781

Merged
merged 22 commits into from
Apr 8, 2022
Merged

Perspective restore() config #2781

merged 22 commits into from
Apr 8, 2022

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Apr 5, 2022

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #2781 (1e9c8c0) into master (ebeeb53) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2781   +/-   ##
=======================================
  Coverage   41.07%   41.07%           
=======================================
  Files         561      561           
  Lines       25739    25739           
  Branches     3551     3551           
=======================================
  Hits        10572    10572           
  Misses      14380    14380           
  Partials      787      787           
Flag Coverage Δ
api-python 90.71% <ø> (ø)
catalog 13.16% <0.00%> (ø)
lambda 87.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...atalog/app/components/Preview/loaders/summarize.ts 0.00% <ø> (ø)
...ents/Preview/renderers/Perspective/Perspective.tsx 0.00% <0.00%> (ø)
catalog/app/utils/perspective.ts 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fiskus fiskus marked this pull request as ready for review April 6, 2022 08:30
@fiskus fiskus requested a review from nl0 April 6, 2022 09:10
@@ -63,6 +63,10 @@
}
}
},
"config": {
"description": "Perspctive specific option. Restores config from .save()",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akarve pls wordsmith

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akarve I'm going to merge it, feel free to point me out to different wording here on in Slack

@fiskus fiskus merged commit 548ecdc into master Apr 8, 2022
@fiskus fiskus deleted the perspective-restore branch April 8, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants