Remove marketing blocks from PRODUCT mode home page #2780
Conversation
fiskus
commented
Apr 5, 2022
fiskus
commented
Codecov Report
@@ Coverage Diff @@
## master #2780 +/- ##
=======================================
Coverage 41.08% 41.08%
=======================================
Files 561 561
Lines 25733 25733
Branches 3547 3547
=======================================
Hits 10572 10572
+ Misses 14375 14374 -1
- Partials 786 787 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
| @@ -389,13 +389,13 @@ function useLinks(): LinkDescriptor[] { | |||
| label: 'URI', | |||
| path: paths.uriResolver, | |||
| }, | |||
| { href: URLS.docs, label: 'Docs' }, | |||
| cfg.mode !== 'PRODUCT' && { href: URLS.docs, label: 'Docs' }, | |||
There was a problem hiding this comment.
i think we should keep the documentation link
There was a problem hiding this comment.
Aneesh asked to remove it. I thought we should keep it too.
But after removing all marketing blocks docs link in the footer become visible now, and probably redundant
There was a problem hiding this comment.
Also, we have docs links in-place where something goes wrong and user should want to check the docs :)
| {showMarketingBlocks && <CaseStudies />} | ||
| {showMarketingBlocks && <Testimonials />} | ||
| {showMarketingBlocks && <Platform />} | ||
| {showMarketingBlocks && <Highlights />} |
There was a problem hiding this comment.
we could wrap these into a fragment and keep only one check before it, e.g.:
{showMarketingBlocks && (
<>
<Showcase />
<UseQuilt />
...
</>
)}
no big deal tho, up to you
