Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview CZI files #2727

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Preview CZI files #2727

merged 2 commits into from
Mar 10, 2022

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Mar 10, 2022

@nl0 nl0 requested a review from fiskus March 10, 2022 14:59
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2727 (f839e71) into master (1837d25) will decrease coverage by 47.92%.
The diff coverage is n/a.

❗ Current head f839e71 differs from pull request most recent head ad4d203. Consider uploading reports for the commit ad4d203 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2727       +/-   ##
===========================================
- Coverage   89.45%   41.52%   -47.93%     
===========================================
  Files          74      545      +471     
  Lines        9406    25295    +15889     
  Branches        0     3431     +3431     
===========================================
+ Hits         8414    10504     +2090     
- Misses        992    14017    +13025     
- Partials        0      774      +774     
Flag Coverage Δ
api-python 90.71% <ø> (+0.12%) ⬆️
catalog 13.10% <ø> (?)
lambda 87.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Thumbnail/Thumbnail.js 26.50% <ø> (ø)
catalog/app/utils/json-schema/index.js 100.00% <0.00%> (ø)
catalog/app/components/Sparkline/Sparkline.tsx 0.00% <0.00%> (ø)
catalog/app/utils/search.js 0.00% <0.00%> (ø)
catalog/app/utils/Okta.js 17.50% <0.00%> (ø)
catalog/app/utils/validators.js 55.17% <0.00%> (ø)
catalog/app/website/components/Lede/Lede.tsx 0.00% <0.00%> (ø)
catalog/app/components/Pagination2/index.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/requests/package.ts 34.09% <0.00%> (ø)
catalog/app/components/BucketIcon/BucketIcon.tsx 35.29% <0.00%> (ø)
... and 465 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1837d25...ad4d203. Read the comment docs.

@nl0 nl0 merged commit 15136fc into master Mar 10, 2022
@nl0 nl0 deleted the preview-czi-images branch March 10, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants