-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gzip deserialization #2677
Add gzip deserialization #2677
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2677 +/- ##
==========================================
+ Coverage 41.36% 41.45% +0.08%
==========================================
Files 536 536
Lines 24751 24791 +40
Branches 3380 3380
==========================================
+ Hits 10239 10276 +37
- Misses 13739 13742 +3
Partials 773 773
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm gonna test it today. Would you add a CHANGELOG entry and update docs?
api/python/quilt3/formats.py
Outdated
|
||
class GzipCompressionHandler(BaseCompressionHandler): | ||
"""Compression handler for gzip""" | ||
handled_extensions = ['gz'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also do this? Apparently customer has both in S3.
handled_extensions = ['gz'] | |
handled_extensions = ['gz', 'gzip'] |
Co-authored-by: Aneesh Karve <[email protected]>
Hopefully fixes the cov error.
Automatically decompress gzip'ed package entries.