Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gzip deserialization #2677

Merged
merged 5 commits into from
Feb 14, 2022
Merged

Add gzip deserialization #2677

merged 5 commits into from
Feb 14, 2022

Conversation

dimaryaz
Copy link
Contributor

@dimaryaz dimaryaz commented Feb 10, 2022

Automatically decompress gzip'ed package entries.

@dimaryaz dimaryaz requested a review from akarve February 10, 2022 06:44
@dimaryaz dimaryaz self-assigned this Feb 10, 2022
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #2677 (3794f69) into master (bda772c) will increase coverage by 0.08%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2677      +/-   ##
==========================================
+ Coverage   41.36%   41.45%   +0.08%     
==========================================
  Files         536      536              
  Lines       24751    24791      +40     
  Branches     3380     3380              
==========================================
+ Hits        10239    10276      +37     
- Misses      13739    13742       +3     
  Partials      773      773              
Flag Coverage Δ
api-python 90.61% <92.85%> (+0.01%) ⬆️
catalog 13.20% <ø> (ø)
lambda 88.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/python/quilt3/formats.py 81.68% <90.90%> (+0.79%) ⬆️
api/python/quilt3/packages.py 92.87% <100.00%> (+0.05%) ⬆️
api/python/tests/integration/test_packages.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bda772c...3794f69. Read the comment docs.

Copy link
Member

@akarve akarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm gonna test it today. Would you add a CHANGELOG entry and update docs?

@akarve akarve self-requested a review February 11, 2022 03:54
@dimaryaz dimaryaz changed the title WIP: Add gzip deserialization Add gzip deserialization Feb 11, 2022

class GzipCompressionHandler(BaseCompressionHandler):
"""Compression handler for gzip"""
handled_extensions = ['gz']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also do this? Apparently customer has both in S3.

Suggested change
handled_extensions = ['gz']
handled_extensions = ['gz', 'gzip']

docs/CHANGELOG.md Outdated Show resolved Hide resolved
@akarve akarve self-requested a review February 12, 2022 01:14
@dimaryaz dimaryaz merged commit 0b7a136 into master Feb 14, 2022
@dimaryaz dimaryaz deleted the gzip branch February 14, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants