Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't support packages in out-of-stack-buckets #2641

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Jan 27, 2022

@nl0 nl0 requested a review from fiskus January 27, 2022 14:38
return inStack || localMode ? (
<>{children}</>
) : (
<Message headline="Packages not supported">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akarve wordsmith pls if necessary

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #2641 (7dd9043) into master (61e22dd) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 7dd9043 differs from pull request most recent head e9c98b3. Consider uploading reports for the commit e9c98b3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2641      +/-   ##
==========================================
- Coverage   41.87%   41.82%   -0.06%     
==========================================
  Files         535      536       +1     
  Lines       24661    24691      +30     
  Branches     3350     3352       +2     
==========================================
  Hits        10327    10327              
- Misses      13562    13592      +30     
  Partials      772      772              
Flag Coverage Δ
api-python 90.27% <ø> (ø)
catalog 13.36% <0.00%> (-0.03%) ⬇️
lambda 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../app/containers/Bucket/PackageList/PackageList.tsx 0.00% <0.00%> (ø)
...iners/Bucket/PackageRevisions/PackageRevisions.tsx 0.00% <0.00%> (ø)
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% <0.00%> (ø)
...alog/app/containers/Bucket/WithPackagesSupport.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e22dd...e9c98b3. Read the comment docs.

@nl0 nl0 merged commit 2fa68a7 into master Jan 27, 2022
@nl0 nl0 deleted the dont-support-packages-out-of-stack branch January 27, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants