Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF preview: count pages again #2621

Merged
merged 2 commits into from
Jan 18, 2022
Merged

PDF preview: count pages again #2621

merged 2 commits into from
Jan 18, 2022

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Jan 18, 2022

Description

Partially reverts 4eb2c68

TODO

@sir-sigurd sir-sigurd requested a review from nl0 January 18, 2022 11:15
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #2621 (8fdf2ec) into master (e8ff056) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2621      +/-   ##
==========================================
- Coverage   41.99%   41.98%   -0.01%     
==========================================
  Files         532      532              
  Lines       24593    24598       +5     
  Branches     3334     3336       +2     
==========================================
  Hits        10328    10328              
- Misses      13500    13503       +3     
- Partials      765      767       +2     
Flag Coverage Δ
api-python 90.26% <ø> (ø)
catalog 13.41% <0.00%> (-0.01%) ⬇️
lambda 88.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Preview/loaders/Pdf.js 0.00% <0.00%> (ø)
catalog/app/components/Preview/renderers/Pdf.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ff056...8fdf2ec. Read the comment docs.

Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@sir-sigurd sir-sigurd merged commit b6828f3 into master Jan 18, 2022
@sir-sigurd sir-sigurd deleted the pdf-thumb-pages branch January 18, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants