Fix performance of countPages in thumbnail lambda #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2616 +/- ##
==========================================
+ Coverage 41.98% 41.99% +0.01%
==========================================
Files 532 532
Lines 24599 24593 -6
Branches 3334 3334
==========================================
+ Hits 10327 10328 +1
+ Misses 13507 13500 -7
Partials 765 765
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
akarve
approved these changes
Jan 18, 2022
nl0
approved these changes
Jan 18, 2022
sir-sigurd
force-pushed
the
pdf-pages-count
branch
from
5066a06
to
2bdef2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
pdfinfooutput instead of rendering all pages to count pages.TODO